Skip to content

Conversation

@stephen-riggs
Copy link
Contributor

No description provided.

tieneupin

This comment was marked as outdated.

@tieneupin tieneupin dismissed their stale review January 9, 2025 18:10

Outdated

@tieneupin
Copy link
Contributor

tieneupin commented Jan 9, 2025

I've set the value type for ispyb_credentials to be Optional[Path], since we are dealing with full file paths here. murfey_db_credentials and rabbitmq_credentials are Path objects, since they're integral to Murfey's operation.

@codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.06%. Comparing base (f9739aa) to head (4da0bc9).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   27.05%   27.06%   +0.01%     
==========================================
  Files          75       75              
  Lines       10180    10182       +2     
  Branches     1343     1343              
==========================================
+ Hits         2754     2756       +2     
  Misses       7336     7336              
  Partials       90       90              

@tieneupin tieneupin added the server Relates to the server component label Jan 10, 2025
@tieneupin tieneupin merged commit 1db4ee4 into main Feb 11, 2025
17 checks passed
@tieneupin tieneupin deleted the ispyb-creds branch February 11, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants