Skip to content

Conversation

@tieneupin
Copy link
Contributor

Now that we've removed the Zocalo configuration dependency, we import and use PikaTransport directly to load the RabbitMQ configuration

@tieneupin tieneupin added bug Something isn't working server Relates to the server component labels Jan 9, 2025
@tieneupin tieneupin requested a review from d-j-hatton January 9, 2025 16:30
@tieneupin tieneupin self-assigned this Jan 9, 2025
@tieneupin tieneupin changed the title Use PikaTransport object directly to load RabbitMQ credentials Load RabbitMQ credentials directly using PikaTransport object Jan 9, 2025
@codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 26.95%. Comparing base (46ad843) to head (1ffb365).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #434   +/-   ##
=======================================
  Coverage   26.95%   26.95%           
=======================================
  Files          75       75           
  Lines       10243    10243           
  Branches     1351     1351           
=======================================
  Hits         2761     2761           
  Misses       7392     7392           
  Partials       90       90           

@tieneupin tieneupin merged commit f9739aa into main Jan 10, 2025
17 checks passed
@tieneupin tieneupin deleted the transport-fix branch January 10, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants