Skip to content

Modified MachineConfig Pydantic model: Turned the 'create_directories' field from a dict to a list#429

Merged
tieneupin merged 4 commits intomainfrom
machine-config-fix
Feb 11, 2025
Merged

Modified MachineConfig Pydantic model: Turned the 'create_directories' field from a dict to a list#429
tieneupin merged 4 commits intomainfrom
machine-config-fix

Conversation

@tieneupin
Copy link
Contributor

Looking through the Murfey source code, there doesn't appear to be a single instance where the keys of the dictionary in the create_directories field come into play. This PR simplifies the MachineConfig Pydantic model by changing the dictionary into a list instead.

@tieneupin tieneupin self-assigned this Jan 8, 2025
@codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 27.29%. Comparing base (42b31d2) to head (2b7241d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #429   +/-   ##
=======================================
  Coverage   27.29%   27.29%           
=======================================
  Files          78       78           
  Lines       10182    10182           
  Branches     1358     1358           
=======================================
  Hits         2779     2779           
  Misses       7308     7308           
  Partials       95       95           

@tieneupin tieneupin merged commit 65049b0 into main Feb 11, 2025
17 checks passed
@tieneupin tieneupin deleted the machine-config-fix branch February 11, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants