Make ISPyB records for atlas, grid squares and foil holes#426
Merged
d-j-hatton merged 10 commits intomainfrom Jan 8, 2025
Merged
Make ISPyB records for atlas, grid squares and foil holes#426d-j-hatton merged 10 commits intomainfrom
d-j-hatton merged 10 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 27.25% 26.05% -1.21%
==========================================
Files 75 76 +1
Lines 10002 11439 +1437
Branches 1319 1739 +420
==========================================
+ Hits 2726 2980 +254
- Misses 7186 8338 +1152
- Partials 90 121 +31 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
stephen-riggs
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is complicated and almost certainly buggy. The problems arise because we need to allow for grid square and foil hole updates when metadata becomes available.