Conversation
…of CLEM workflow for a given image series
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
==========================================
- Coverage 27.25% 26.37% -0.89%
==========================================
Files 75 75
Lines 10002 10897 +895
Branches 1319 1638 +319
==========================================
+ Hits 2726 2874 +148
- Misses 7186 7910 +724
- Partials 90 113 +23 |
tieneupin
changed the title
| images: list[Path] | ||
| metadata: Path | ||
| # Optional processing parameters | ||
| crop_to_n_frames: Optional[int] = None |
Contributor
There was a problem hiding this comment.
As noted on the cryoemservices PR, these could possibly default to something else rather than None
Contributor
Author
There was a problem hiding this comment.
Do these still apply after our discussion as a group earlier, or are you have to have them as None?
| images: list[Path], | ||
| metadata: Path, | ||
| # Optional processing parameters | ||
| crop_to_n_frames: Optional[int] = None, |
Contributor
There was a problem hiding this comment.
As above. Something to consider
…pdated validation checks accordingly
… to both the LIF and TIFF workflows
… to 'processing_params'
d-j-hatton
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also migrates the Pydantic model associated with the TIFF file processing workflow to the CLEM API page, to keep supporting objects localised.
This PR will need to be deployed alongside this PR due to breaking changes.