Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
=======================================
Coverage 31.85% 31.86%
=======================================
Files 90 90
Lines 10726 10762 +36
Branches 1416 1422 +6
=======================================
+ Hits 3417 3429 +12
- Misses 7193 7215 +22
- Partials 116 118 +2 🚀 New features to boost your workflow:
|
…e_versions' keys in the 'MachineConfig' model; added helper model to correctly validate the magnification calibration table
…ator' to the 'File' BaseModel to do so
tieneupin
approved these changes
Jun 26, 2025
Contributor
tieneupin
left a comment
There was a problem hiding this comment.
Made corrections to a few missed spots, and it seems to be working now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the changes needed for
pydantic2.In doing this, we also upgrade to
sqlalchemy2, so one change has also been made for that.Also this removes the
procrunnerdependency in favour of directly callingsubprocess.Before merging this we need to be able to run MSYS2 or a similar rust-compatible terminal on the microscopes.
Closes #315