Conversation
|
If hatch will only be temporary would it be better to stick with tox for now using tox-uv? |
|
Relates to #246, just to link issues |
OCopping
force-pushed
the
move-to-uv
branch
3 times, most recently
from
286c223 to
455efa5
Compare
|
@OCopping Should probably also update the tests to use |
I have some of those changes uncommited locally; was trying to fix the CI first |
coretl
left a comment
coretl
left a comment
There was a problem hiding this comment.
I got half way through a review a while back, not sure if these are still relevant, but I'll submit them now anyway. I'll try and find time to do a proper review next week
…ing test_template_mypy
callumforrester
force-pushed
the
move-to-uv
branch
from
30c743a to
45c895a
Compare
Otherwise ruff complains, the template tests catch this anyway
|
Still need to update the docs |
AlexanderWells-diamond
left a comment
AlexanderWells-diamond
left a comment
There was a problem hiding this comment.
Overall this looks fine to me; most of my comments are just minor questions/clarifications.
I tried coverting aioca to use this version of the template and it appears to have run as expected, with failures explainable as issues with that project, not the template itself: DiamondLightSource/aioca#74
template/{% if git_platform=="github.com" %}.github{% endif %}/workflows/ci.yml.jinja
Show resolved
Hide resolved
Co-authored-by: Alexander Wells <79699091+AlexanderWells-diamond@users.noreply.github.com>
But add extra docs-autobuild target
Otherwise docs autobuild doesn't work as the forward kicks in before sphinx can start the server
OCopping
requested review from
AlexanderWells-diamond,
callumforrester and
coretl
and removed request for
callumforrester
AlexanderWells-diamond
left a comment
AlexanderWells-diamond
left a comment
There was a problem hiding this comment.
Looks good to me
6 participants
This PR aims to move away from using the
venv/toxsetup for a more modernuv(andtox-uvuntiluvadds it's own form of runners) approach.