Repository navigation
Diamond2 conversion2 - #5
Merged
Merged
Conversation
ptsOSL
force-pushed
the
diamond2-conversion2
branch
2 times, most recently
from
September 15, 2026 14:18
401d8cf to
e4a1f2a
Compare
Rather than constructing the RM in the order defined in the mml tuneRM file, we do it in the order defined in tunefb_offsets.py
We now find our config files from either diamond2opsdata or diamondopsdata depending on the ringmode
ptsOSL
force-pushed
the
diamond2-conversion2
branch
from
September 16, 2026 10:54
fa5051a to
4e03ab6
Compare
This ensures the caputs complete before continuing and anecdotally has been seen to improve results against the Virtac which responds much slower than the real machine.
When running in D2 mode, you get different ringmodes to choose which load different lattices and make different PVs
ptsOSL
force-pushed
the
diamond2-conversion2
branch
from
September 16, 2026 11:00
4e03ab6 to
4bdbe8a
Compare
MJGaughran
reviewed
Sep 16, 2026
| rmats = [] | ||
|
|
||
| # We build the response matrix out of the tune quad families, making sure | ||
| # that they are ordered in the same order as defined elsewhere. |
Collaborator
There was a problem hiding this comment.
Where is elsewhere? MML config? Inside dls_slow_feedbacks? All of them?
Collaborator
Author
There was a problem hiding this comment.
Inside dls_slow_feedbacks. Previously we just assumed the data in mml was in the order we required, now we check and reorder if necessary.
Collaborator
There was a problem hiding this comment.
Could you make this explicit in the comment?
Collaborator
Author
There was a problem hiding this comment.
I have updated the comment
ptsOSL
force-pushed
the
diamond2-conversion2
branch
from
September 16, 2026 13:06
a7cf2b4 to
e888c1f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 47.55% 48.05% +0.49%
==========================================
Files 16 16
Lines 1659 1698 +39
==========================================
+ Hits 789 816 +27
- Misses 870 882 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was actually slowing Virtac. This is because Virtac would see the changes to the first pv in the list and then recalculate before the others had taken effect. As wait=True, tunefb would have to wait for Virtac to recalculate and then read in the remainder of the caputs at which point tunefb could then move on. In some ways this was the correct behaviour, but it was causing issues.
ptsOSL
force-pushed
the
diamond2-conversion2
branch
from
September 21, 2026 10:34
d235679 to
614cbee
Compare
MJGaughran
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.