Repository navigation
HLA-1164 Rework Feedback Run Times - #97
Merged
Merged
Conversation
SOFB_RUN_TIME and FOFB_RUN_TIME are now used as timeouts to limit the max time the feedbacks can run. If the timeout is reached, the feedbacks will exit and a warning is produced to the user. If the max orbit reaches its thresold value early, then the program will continue without having to wait the full duration.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
- Coverage 46.15% 46.06% -0.10%
==========================================
Files 20 20
Lines 2277 2286 +9
==========================================
+ Hits 1051 1053 +2
- Misses 1226 1233 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ptsOSL
reviewed
Sep 28, 2026
ptsOSL
reviewed
Sep 28, 2026
ptsOSL
left a comment
Contributor
There was a problem hiding this comment.
In your first screenshot, the log says that the orbit is larger than the user requested max of 7.5um. But then in a later line, it says that the SOFB timeout has been reached with a final orbit of 2.93um, but this is less than the max, so the new function should have returned without this warning?
ptsOSL
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See warning message:

See updated settings for SOFB/FOFB:

(Apologies for dark mode)