Skip to content

HLA-1164 Rework Feedback Run Times - #97

Merged
MichaelStubbings merged 4 commits into
mainfrom
hla-1164-rework-feedback-run-times
Sep 29, 2026
Merged

MichaelStubbings merged 4 commits into
mainfrom
hla-1164-rework-feedback-run-times

Conversation

@MichaelStubbings

@MichaelStubbings MichaelStubbings commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor
  • Increases SOFB RUN TIME from 10s->15s
  • Renames SOFB/FOFB_RUN_TIME to SOFB/FOFB_TIMEOUT
  • While the feedbacks are running a check is made whether the max orbit is reached: If reached, the code returns early. If not, a warning is logged.

See warning message:
Screenshot from 2026-09-29 09-58-52

See updated settings for SOFB/FOFB:
Screenshot from 2026-09-25 11-35-29

(Apologies for dark mode)

SOFB_RUN_TIME and FOFB_RUN_TIME are now used as timeouts to limit the
max time the feedbacks can run. If the timeout is reached, the feedbacks
will exit and a warning is produced to the user. If the max orbit
reaches its thresold value early, then the program will continue
without having to wait the full duration.
@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.06%. Comparing base (b70f6ff) to head (8be5082).

Files with missing lines Patch % Lines
src/dls_bba/machine.py 15.38% 11 Missing ⚠️
src/dls_bba/gui.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   46.15%   46.06%   -0.10%     
==========================================
  Files          20       20              
  Lines        2277     2286       +9     
==========================================
+ Hits         1051     1053       +2     
- Misses       1226     1233       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/dls_bba/machine.py

@ptsOSL ptsOSL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your first screenshot, the log says that the orbit is larger than the user requested max of 7.5um. But then in a later line, it says that the SOFB timeout has been reached with a final orbit of 2.93um, but this is less than the max, so the new function should have returned without this warning?

@MichaelStubbings
MichaelStubbings merged commit c38ca74 into main Sep 29, 2026
7 of 9 checks passed
@MichaelStubbings
MichaelStubbings deleted the hla-1164-rework-feedback-run-times branch September 29, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants