-
Notifications
You must be signed in to change notification settings - Fork 0
Improve schema docs and regenerate schemas automatically #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Regenerate the JSON schemas | ||
|
|
||
| The JSON schema files under `src/deploy_tools/models/schemas` are generated from the | ||
| Pydantic models in `src/deploy_tools/models` by | ||
| `deploy_tools.models.schema.generate_schema`. They are checked in and do not update | ||
| automatically, so they must be regenerated and committed after changing any model. | ||
|
|
||
| A `generate-schema` pre-commit hook does this for you: when you commit a change to | ||
| any file under `src/deploy_tools/models`, it regenerates the schemas. If they changed, | ||
| pre-commit reports the modified files and aborts the commit, so you just `git add` the | ||
| schemas and commit again. | ||
|
|
||
| If you bypass the hooks (for example with `git commit --no-verify`), regenerate the | ||
| schemas manually. The simplest way is the **Generate Schema** VSCode task (see | ||
| [the VSCode tasks guide](vscode-tasks.md)), which writes to the correct location. | ||
| Equivalently, run the CLI, pointing it at that folder: | ||
|
|
||
| ```bash | ||
| deploy-tools schema src/deploy_tools/models/schemas | ||
| ``` | ||
|
|
||
| Either way, commit the regenerated files alongside your model change. CI fails if they | ||
| are out of date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.