Skip to content

Conversation

@ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-2031

Summary:

Some people might prefer to view all data collections, rather than them grouped together. The backend already supports this (see multicrystal processing page), so just need a UI element for it.

Changes:

  • Add a nice looking toggle (really a checkbox) at the top of the data collection page
  • Store the value in local storage
  • Send the value as a query parameter when fetching data collections
  • Switch ccp4 cloud credentials to use local storage rather than cookies. Cookies are sent to the server on every request, which is unnecessary, and can also lead to surprising results where cookies and url parameters clash.

To test:

  • Go to a visit with grouped data collections, eg /dc/visit/mx23694-154 should have grouped grid scans on the first page
  • Check a toggle appears in the top right, and that turning it on shows all the grid scans separately, not grouped together
  • Check switching the toggle off groups the grid scans again
  • Check the toggle remains visible and in the same position if you go to View All Data from the main menu (ie /dc)
  • Check the toggle remains visible and in the same position if you view a sample with data collections (eg /samples/sid/7093140)
  • Check the toggle is not displayed if you click into a group (eg /dc/visit/mx23694-154/dcg/17555052), a processing job group (eg /dc/pjid/35444304), or a single data collection (eg /dc/visit/mx23694-154/id/21392025)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants