Fix polygon manipulator aabb computation #903
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
June 25, 2025 18:29
Comment on lines
+76
to
+89
| uint32_t vertex_i; | ||
| const auto indexBuffer = geo->getIndexView().getPointer(); | ||
| switch (geo->getIndexType()) | ||
| { | ||
| case EIT_16BIT: | ||
| vertex_i = reinterpret_cast<const uint16_t*>(indexBuffer)[i]; | ||
| break; | ||
| case EIT_32BIT: | ||
| vertex_i = reinterpret_cast<const uint32_t*>(indexBuffer)[i]; | ||
| break; | ||
| default: | ||
| assert(false); | ||
| break; | ||
| } |
There was a problem hiding this comment.
its better to pack up the whole for loop into a templated lambda, and hoist the switch above (so it dispatches a separate specialized for loop per case)
this way you avoid dealing with the switch and different inted buffer decodes at every index
| { | ||
| uint32_t vertex_i; | ||
| const auto indexBuffer = geo->getIndexView().getPointer(); | ||
| switch (geo->getIndexType()) |
There was a problem hiding this comment.
this is meant to be for Graphics Pipelines, use non-index-view specific methods (decodeElement like a normal view) to decode indices (this way you'll be able to support int8 indices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix AABB computation on cpu polygon geometry