Mesh loaders #197

devshgraphicsprogramming · 2025-06-16T11:43:51Z

No description provided.

…ek's help Yes geometry creator scene default SPIR-V shaders are gone

…common`

… tmp trick #include "nbl/examples/common/SimpleWindowedApplication.hpp" #include "nbl/examples/common/InputSystem.hpp" #include "nbl/examples/common/CEventCallback.hpp" #include "nbl/examples/cameras/CCamera.hpp"

…ncluded in PCH now though the example doesn't compile anyway (misses imgui link and more)

… into project to allow build all at once

… Renderer

devshgraphicsprogramming · 2025-06-18T13:29:38Z

09_GeometryCreator/include/common.hpp

+// TODO: @AnastaZIuk do we even make that explicit?
+#include "nbl/examples/PCH.hpp"


examples/examples

devshgraphicsprogramming · 2025-06-18T13:36:27Z

61_UI/CMakeLists.txt

-	nbl_create_executable_project("${NBL_EXTRA_SOURCES}" "" "${NBL_INCLUDE_SERACH_DIRECTORIES}" "${NBL_LIBRARIES}" "${NBL_EXECUTABLE_PROJECT_CREATION_PCH_TARGET}")
-	LINK_BUILTIN_RESOURCES_TO_TARGET(${EXECUTABLE_NAME} geometryCreatorSpirvBRD)
+
+	# TODO; Arek I removed `NBL_EXECUTABLE_PROJECT_CREATION_PCH_TARGET` from the last parameter here, doesn't this macro have 4 arguments anyway !?
+	nbl_create_executable_project("${NBL_EXTRA_SOURCES}" "" "${NBL_INCLUDE_SERACH_DIRECTORIES}" "${NBL_LIBRARIES}")
+	# TODO: Arek temporarily disabled cause I haven't figured out how to make this target yet
+	# LINK_BUILTIN_RESOURCES_TO_TARGET(${EXECUTABLE_NAME} nblExamplesGeometrySpirvBRD)


touch up in #196

devshgraphicsprogramming · 2025-06-18T13:37:04Z

09_GeometryCreator/CMakeLists.txt

+nbl_create_executable_project("" "" "${NBL_INCLUDE_SERACH_DIRECTORIES}" "" "")
+# TODO: Arek temporarily disabled cause I haven't figured out how to make this target yet
+# LINK_BUILTIN_RESOURCES_TO_TARGET(${EXECUTABLE_NAME} nblExamplesGeometrySpirvBRD)


@AnastaZIuk touch up #196

devshgraphicsprogramming · 2025-06-18T13:42:12Z

common/src/geometry/CMakeLists.txt

@@ -1 +0,0 @@
-add_subdirectory(creator EXCLUDE_FROM_ALL)


@AnastaZIuk use n4ce tool here

devshgraphicsprogramming · 2025-06-18T13:45:39Z

common/src/nbl/examples/cameras/CMakeLists.txt

+# header only currently
+
+#set(NBL_EXAMPLES_CAMERA_LIB_SOURCES
+#    "${CMAKE_CURRENT_SOURCE_DIR}/*.cpp"
+#)
+
+#nbl_create_ext_library_project(ExampleCameras "" "${NBL_EXAMPLES_CAMERA_LIB_SOURCES}" "" "" "")


@AnastaZIuk write example code how to deal with this

I'd add sources to PARENT_SCOPE Common target not make new static libs, to avoid 1GB PCH per lib.

Use `ICPUPolygonGeometry::exportForBLAS` to make the Triangle Geometries https://github.com/Devsh-Graphics-Programming/Nabla/blob/1f52d2f48ff077cb430cc78285fb12dd7e093f74/include/nbl/asset/IPolygonGeometry.h#L209

…ude/nbl/examples` under `nbl/examples` either as dir or builtin archive

…screen

devshgraphicsprogramming · 2025-06-20T10:46:31Z

71_RayTracingPipeline/include/common.hpp

+struct ObjectDrawHookCpu
+{
+	nbl::core::matrix3x4SIMD model;
+	ObjectMeta meta;
+};
+
+struct ReferenceObjectCpu
+{
+	ObjectMeta meta;
+	core::smart_refctd_ptr<ICPUPolygonGeometry> data;
+	Material material;
+  core::matrix3x4SIMD transform;
+};


that stuff is old and disgusting clean up a bit

…h_loaders

… the examples which are WIP on this branch

…les_tests w.r.t. the question of `MonoAssetManagerAndBuiltinResourceApplication.hpp` There really isn't a usecase for: - embedding Nabla resources but not embedding example (there's no harm in Nabla resources not being embedded) - even more strangely, not embedding Nabla resources, but embedding example.

devshgraphicsprogramming · 2025-06-21T22:23:32Z

23_Arithmetic2UnitTest/app_resources/testWorkgroup.comp.hlsl

-#include "../../common/include/WorkgroupDataAccessors.hlsl"
+#include "nbl/examples/workgroup/DataAccessors.hlsl"


@AnastaZIuk I need help here, the NblExamples project also needs to have its own builtins thing for HLSL headers

devshgraphicsprogramming · 2025-06-21T22:25:35Z

CMakeLists.txt

+	add_subdirectory(67_RayQueryGeometry EXCLUDE_FROM_ALL) # TODO: resurrect before `mesh_loaders` merge
+	add_subdirectory(68_JpegLoading)

-  	add_subdirectory(70_FLIPFluids EXCLUDE_FROM_ALL)
-	add_subdirectory(71_RayTracingPipeline EXCLUDE_FROM_ALL)
+  	add_subdirectory(70_FLIPFluids)
+	add_subdirectory(71_RayTracingPipeline EXCLUDE_FROM_ALL) # TODO: resurrect before `mesh_loaders` merge


@kevyuu in your PR with fixes for 67 and 71, you need to remove those EXCLUDE_FROM_ALL

devshgraphicsprogramming · 2025-06-21T22:27:43Z

common/include/nbl/examples/geometry/CSimpleDebugRenderer.hpp

+// TODO: Arek bring back
+//#include "nbl/examples/geometry/spirv/builtin/CArchive.h"
+//#include "nbl/examples/geometry/spirv/builtin/builtinResources.h"


there could just be one general builtin archive for nbl/examples

devshgraphicsprogramming · 2025-06-21T22:29:19Z

common/include/nbl/examples/geometry/CSimpleDebugRenderer.hpp

+				const auto bundle = assMan->getAsset("nbl/examples/geometry/shaders/unified.hlsl",{});
+// TODO: Arek
+				//const auto bundle = assMan->getAsset("nbl/examples/geometry/shaders/unified.spv",{});


@AnastaZIuk n4ce tool in 2 configs:

read spir-v from disk (build directory of example, but mounted)

read spir-v from builtin

but we always use nsc.exe to do a build step to produce the spirv

devshgraphicsprogramming · 2025-06-21T22:31:58Z

09_GeometryCreator/main.cpp

+			// TODO: this is plain wrong Arek
+			m_system->mount(make_smart_refctd_ptr<system::CMountDirectoryArchive>(localInputCWD/"../common/include/nbl/examples",smart_refctd_ptr(m_logger),m_system.get()),"nbl/examples");
+			m_system->mount(make_smart_refctd_ptr<system::CMountDirectoryArchive>(localInputCWD/"../common/src/nbl/examples",smart_refctd_ptr(m_logger),m_system.get()),"nbl/examples");


@AnastaZIuk I think I'll handle this in MonoAssetManagerAndBuiltinResourceApplication

btw when embed resources is OFF, these should be mounted AND corresponding build dir which I guess will be just src/nbl/examples but somewhere in build dir (if there's for example SPIR-V being made with NSC from stuff in src/nbl/examples

…ceApplication` in two

…treatment to NOT include `this_example/CArchive`

devshgraphicsprogramming · 2025-06-22T00:03:40Z

common/include/nbl/examples/common/BuiltinResourcesApplication.hpp

+// TODO: make the `this_example` optional, only if the example has builtins
+#include "nbl/this_example/builtin/CArchive.h"


@YasInvolved I think this can be done with __has_include https://en.cppreference.com/w/cpp/preprocessor/include

devsh and others added 18 commits May 27, 2025 10:51

Lets remake the STL/PLY loaders

0ed8dc4

first outline

fef1cd5

outline how I want stuff reorganised

157bd8f

temporarily disable some things that I couldn't figure out withour Ar…

8370719

…ek's help Yes geometry creator scene default SPIR-V shaders are gone

factored out the CSwapchainFramebuffersAndDepth into `nbl/examples/…

83443a7

…common`

rework PCH for examples, save work and test with 01 - successfully

6c78e29

remove old header references from 29_MeshLoaders/main.cpp which are i…

ed51dee

…ncluded in PCH now though the example doesn't compile anyway (misses imgui link and more)

wipe all EXCLUDE_FROM_ALL except common directory, group all examples…

971ee34

… into project to allow build all at once

use NBL_ADJUST_FOLDERS with examples namespace

c9f610f

prep the push constants a little and move onto scene conversion

d1a8113

correct small typos, get stuff to compile

629a0ac

add more test geometries

37330ab

fire up the converter and handle ownership between queues

5200ea1

use Asset Converter for ICPUPolygonGeometry, and split into Scene and…

272a269

… Renderer

prep for the final stretch in ex 09 (shaders)

c446d7e

move ex09 renderer to its own include

e76bfcc

prep for shader loading

c3786df

devshgraphicsprogramming commented Jun 18, 2025

View reviewed changes

devsh added 7 commits June 18, 2025 23:00

kill a CMakeLists.txt not used in the example PCH branch

d03f31b

commit shaders somewhere for now

f6aebbf

Merge remote-tracking branch 'remotes/origin/master' into mesh_loaders

00be524

get ex 09 in line with Stageless Shaders

8965fb3

fix up examples before the PCH PR

a860c43

prep example 71 for @kevinyu

2dc2682

Use `ICPUPolygonGeometry::exportForBLAS` to make the Triangle Geometries https://github.com/Devsh-Graphics-Programming/Nabla/blob/1f52d2f48ff077cb430cc78285fb12dd7e093f74/include/nbl/asset/IPolygonGeometry.h#L209

prep example 67 for further work

be46ec3

devsh and others added 10 commits June 19, 2025 01:33

@AnastaZIuk I need your help for getting the mounting of `common/incl…

9aa7483

…ude/nbl/examples` under `nbl/examples` either as dir or builtin archive

prep UI example for further work

846d2fd

note down embedding TODOs for arek

a347562

remove unused shaders

cf4e279

get the example to find shaders and create pipelines, but nothing on …

08c28ef

…screen

scene was empty, no wonder nothing drew

17b0579

index type was not being set

62f1a26

Initial commit for example 71 to use ICPUPolygonGeometry

fcae0b4

pull Matt and resolve conflicts

312ca61

docs docs docs, adjust to comments and test on 01 after updates

e419580

devshgraphicsprogramming commented Jun 20, 2025

View reviewed changes

devsh added 6 commits June 20, 2025 16:54

matrix math in linalg was fine, I made a typo

cfd609c

fix a caption bug

6242357

Merge remote-tracking branch 'remotes/origin/mlBuildUpdates' into mes…

19df6e1

…h_loaders

leave pointers on how to port example 62_CAD, also EXCLUDE_FROM_ALL…

19167c5

… the examples which are WIP on this branch

kill old meshloaders example that didn't work since forever

a0622f3

devshgraphicsprogramming commented Jun 21, 2025

View reviewed changes

devsh added 3 commits June 22, 2025 01:14

Adjust all examples after splitting `MonoAssetManagerAndBuiltinResour…

ce268fb

…ceApplication` in two

correct namespace ambiguities affecting example 23 and 29

20a5438

aaah the BuiltinResourcesApplication.hpp header needs some special …

21a88ff

…treatment to NOT include `this_example/CArchive`

devshgraphicsprogramming commented Jun 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Mesh loaders #197

Mesh loaders #197

Uh oh!

devshgraphicsprogramming commented Jun 16, 2025

Uh oh!

devshgraphicsprogramming Jun 18, 2025

Uh oh!

devshgraphicsprogramming Jun 18, 2025

Uh oh!

devshgraphicsprogramming Jun 18, 2025

Uh oh!

devshgraphicsprogramming Jun 18, 2025

Uh oh!

devshgraphicsprogramming Jun 18, 2025

Uh oh!

devshgraphicsprogramming Jun 20, 2025

Uh oh!

devshgraphicsprogramming Jun 21, 2025

Uh oh!

devshgraphicsprogramming Jun 21, 2025

Uh oh!

devshgraphicsprogramming Jun 21, 2025

Uh oh!

devshgraphicsprogramming Jun 21, 2025

Uh oh!

devshgraphicsprogramming Jun 21, 2025

Uh oh!

devshgraphicsprogramming Jun 21, 2025

Uh oh!

devshgraphicsprogramming Jun 22, 2025

Uh oh!

Uh oh!

		// TODO: @AnastaZIuk do we even make that explicit?
		#include "nbl/examples/PCH.hpp"

		#include "../../common/include/WorkgroupDataAccessors.hlsl"
		#include "nbl/examples/workgroup/DataAccessors.hlsl"

		// TODO: make the `this_example` optional, only if the example has builtins
		#include "nbl/this_example/builtin/CArchive.h"

Mesh loaders #197

Are you sure you want to change the base?

Mesh loaders #197

Uh oh!

Conversation

devshgraphicsprogramming commented Jun 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!