feat(client): add --codecs #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @elmarco |
Signed-off-by: Marc-André Lureau <[email protected]>
Signed-off-by: Marc-André Lureau <[email protected]>
CBenoit
reviewed
May 9, 2025
Comment on lines
+644
to
+662
| /// This function generates a list of client codec capabilities based on the | ||
| /// provided configuration. | ||
| /// | ||
| /// # Arguments | ||
| /// | ||
| /// * `config` - A slice of string slices that specifies which codecs to include | ||
| /// in the capabilities. Codecs can be explicitly turned on ("codec:on") or | ||
| /// off ("codec:off"). | ||
| /// | ||
| /// # List of codecs | ||
| /// | ||
| /// * `remotefx` (on by default) | ||
| /// | ||
| /// # Returns | ||
| /// | ||
| /// A vector of `Codec` structs representing the codec capabilities, or an error | ||
| /// suitable for CLI. | ||
| pub fn client_codecs_capabilities(config: &[&str]) -> Result<BitmapCodecs, String> { | ||
| use std::collections::HashMap; |
There was a problem hiding this comment.
note: I think this kind of CLI-related logic does not belong to ironrdp-pdu. But I have local changes to improve config handling and support the .RDP file format. Maybe we could revisit afterwards.
CBenoit
reviewed
May 9, 2025
| @@ -1,3 +1,4 @@ | |||
| #![allow(clippy::print_stdout)] | |||
There was a problem hiding this comment.
nitpick:
Suggested change
| #![allow(clippy::print_stdout)] | |
| #![allow(clippy::print_stdout)] | |
|
thanks! yes always happy to take suggestions or improvements on top! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "--codecs remotefx:on,..." option to the client.
Depends on #782