Improve .NET example Linux and macOS support (follow up to 437) #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBenoit
commented
Apr 9, 2024
Comment on lines
-15
to
+19
| <PackageReference Include="System.Drawing.Common" Version="8.0.3" /> | ||
| <!-- | ||
| System.Drawing.Common NuGet package is only supported on Windows operating systems. | ||
| One of the recommended alternatives include ImageSharp. | ||
|
|
||
| https://learn.microsoft.com/en-us/dotnet/api/system.drawing?view=net-8.0 | ||
| --> | ||
| <PackageReference Include="SixLabors.ImageSharp" Version="3.1.3" /> |
There was a problem hiding this comment.
Linux and macOS support was removed in .NET 6. Usage of ImageSharp is recommended in those cases.
Coverage Report 🤖 ⚙️Past: New: Diff: -0.00% [this comment will be updated automatically] |
CBenoit
force-pushed
the
dotnet-bindings-cross-platform
branch
2 times, most recently
from
d1236c4 to
e25f1a2
Compare
CBenoit
force-pushed
the
dotnet-bindings-cross-platform
branch
from
e25f1a2 to
e2a81b9
Compare
irvingoujAtDevolution
approved these changes
Apr 9, 2024
CBenoit
force-pushed
the
dotnet-bindings-cross-platform
branch
from
e2a81b9 to
a0e11f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #437
This PR is improving Linux (and macOS) support of the C# bindings. (Especially, build system and example.)
Can you review? @irvingoujAtDevolution