Repository navigation
fix(api): enforce secret-project visibility in search and analytics - #412
Merged
Merged
Conversation
Workspace search, workspace analytics (incl. trend) and the analytics CSV export filtered only by workspace membership, so plain members could read titles, labels, states and assignee emails of secret projects they don't belong to. Apply the same visibility rule used by the project list (public, or a project the caller is a member of; admins see all) at the store layer, and gate per-project analytics through enforceProjectVisibility while also checking the project belongs to the workspace in the URL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Review follow-up: workspace search returned private pages (access=1) to users other than their owner; apply the same owner-only rule the page service uses. Move projectVisibilityFor above enforceProjectVisibility's doc comment, and add tests for private pages and for members whose project membership was removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workspace search, workspace analytics (incl. trend) and the analytics CSV export only checked workspace membership, so a plain member could read titles, states, labels and assignee emails from secret projects they don't belong to.
store.ProjectVisibilitypredicate (same rule asListVisibleByWorkspaceID: public projects + projects the caller belongs to; workspace admins/owners see all), applied to every search group (issues, epics, cycles, modules, views, pages, projects) and every workspace analytics/export query.enforceProjectVisibilityand verify the project belongs to the workspace in the URL.secret_project_visibility_test.gocover outsider (hidden), project member and workspace admin (visible).Note:
GET /projects/:id/analytics/still 500s due to a pre-existing broken query (selects a non-existentstatecolumn); unrelated to access control.AI assistance
🤖 Generated with Claude Code