Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/001 url layout #2

Merged
merged 3 commits into from
Aug 8, 2018
Merged

Issues/001 url layout #2

merged 3 commits into from
Aug 8, 2018

Conversation

duffleit
Copy link
Member

@duffleit duffleit commented Aug 6, 2018

  • Changed Jekyll permalink to just :title. Extended title with episode number. Thus, /2018/08/01/solid.html has changed to /001-solid.
  • Added simple meta-redirect for existing post.

Fixes #1

@duffleit duffleit requested a review from paulroho August 6, 2018 19:25
Merge branch 'master' into issues/001-url-layout
fd07a89 
# Conflicts:
#	_posts/2018-08-01-001-Solid.md
paulroho
paulroho suggested changes Aug 6, 2018
View reviewed changes
Copy link
Contributor

@paulroho paulroho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should include the episode number in one way or another.

  • /episodes/01/solid
  • /01-solid

What do you think?

@duffleit
Copy link
Member Author

duffleit commented Aug 7, 2018

But /001-solid, includes the episode number? :)

@paulroho
Copy link
Contributor

paulroho commented Aug 7, 2018

But where does the episode number come from? I see just permalink: /:title in _config.yml. But of course, I trust you that it works as you say. :)

@duffleit
Copy link
Member Author

duffleit commented Aug 7, 2018

Ah, it‘s working because the file was renamed. :)

@duffleit duffleit merged commit 570ec7a into master Aug 8, 2018
@paulroho paulroho mentioned this pull request Aug 9, 2018
Closed
@duffleit duffleit deleted the issues/001-url-layout branch January 31, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulroho paulroho paulroho requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duffleit @paulroho