Skip to content

Splitter: respect maxSize option where it's possible during collapse and visibility change of its panes (T1323187)#32851

Open
EugeniyKiyashko wants to merge 2 commits intoDevExpress:26_1from
EugeniyKiyashko:26_1_splitter_maxsize
Open

Splitter: respect maxSize option where it's possible during collapse and visibility change of its panes (T1323187)#32851
EugeniyKiyashko wants to merge 2 commits intoDevExpress:26_1from
EugeniyKiyashko:26_1_splitter_maxsize

Conversation

@EugeniyKiyashko
Copy link
Contributor

No description provided.

…and visibility change of its panes (T1323187)
@EugeniyKiyashko EugeniyKiyashko self-assigned this Mar 10, 2026
@EugeniyKiyashko EugeniyKiyashko marked this pull request as ready for review March 10, 2026 14:56
@EugeniyKiyashko EugeniyKiyashko requested a review from a team as a code owner March 10, 2026 14:56
Copilot AI review requested due to automatic review settings March 10, 2026 14:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the internal Splitter layout recalculation logic to respect maxSize constraints during pane collapse/expand and runtime visibility changes, while still allowing the operation to proceed by relaxing maxSize only when the layout cannot be recalculated otherwise.

Changes:

  • Adjusted collapse/visibility layout recalculation to keep maxSize restrictions when possible, retrying without maxSize only if the layout calculation fails.
  • Expanded QUnit coverage for collapse/expand and visibility toggling scenarios involving maxSize, minSize, and collapsedSize.
  • Updated an existing pane-visibility expectation to reflect maxSize-aware redistribution.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/devextreme/js/__internal/ui/splitter/splitter.ts Reworks collapse/visibility change layout calculation to respect maxSize when feasible, with a fallback retry that clears maxSize only if the first pass produces no layout change.
packages/devextreme/testing/tests/DevExpress.ui.widgets/splitter.tests.js Adds/updates test scenarios validating maxSize behavior during collapse/expand and visibility changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants