Splitter: respect maxSize option where it's possible during collapse and visibility change of its panes (T1323187)#32851
Open
EugeniyKiyashko wants to merge 2 commits intoDevExpress:26_1from
Conversation
…and visibility change of its panes (T1323187)
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the internal Splitter layout recalculation logic to respect maxSize constraints during pane collapse/expand and runtime visibility changes, while still allowing the operation to proceed by relaxing maxSize only when the layout cannot be recalculated otherwise.
Changes:
- Adjusted collapse/visibility layout recalculation to keep
maxSizerestrictions when possible, retrying withoutmaxSizeonly if the layout calculation fails. - Expanded QUnit coverage for collapse/expand and visibility toggling scenarios involving
maxSize,minSize, andcollapsedSize. - Updated an existing pane-visibility expectation to reflect
maxSize-aware redistribution.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/ui/splitter/splitter.ts | Reworks collapse/visibility change layout calculation to respect maxSize when feasible, with a fallback retry that clears maxSize only if the first pass produces no layout change. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/splitter.tests.js | Adds/updates test scenarios validating maxSize behavior during collapse/expand and visibility changes. |
dmlvr
approved these changes
Mar 10, 2026
pharret31
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.