fix(analytics): uniqueViewers now uses COUNT(DISTINCT viewer_id) instead of inflated groupBy#449
Open
Srejoye wants to merge 1 commit into
Open
Conversation
…ad of groupBy composite key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #436
The
uniqueViewersfield inGET /api/analytics/overviewwas computed usinggroupBy(['viewerId', 'viewerIp']), which groups on a composite key. A single authenticated viewer visiting from two different IPs produced two group rows and was counted as two unique viewers. Anonymous visitors (viewerId = null) with different IPs each added separate rows, causing severe overcounting on public profiles.Changes
cardView.groupByworkaround with a$queryRawexecutingCOUNT(DISTINCT viewer_id)— the correct SQL the code comment itself described but did not implementviewer_id IS NULL) are explicitly excluded from the distinct count; they represent unidentifiable sessions and cannot be meaningfully deduplicatedBigIntreturned by$queryRawis cast toNumberbefore returningTesting
uniqueViewersmust equal 1uniqueViewersmust equal 3Notes
If tracking anonymous unique visitors becomes a requirement in future, a separate
uniqueAnonymousVisitorsfield usingCOUNT(DISTINCT viewer_ip)can be added with explicit documentation of its limitations.