fix(analytics): totalFollows now counts followers received, not follows performed#448
Open
Srejoye wants to merge 1 commit into
Open
fix(analytics): totalFollows now counts followers received, not follows performed#448Srejoye wants to merge 1 commit into
Srejoye wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #435
The
totalFollowsfield inGET /api/analytics/overviewwas queryingFollowLogwithfollowerId: userId, which counts follows the authenticated user performed on others — the exact opposite of what the dashboard intends to show.Changes
usernamefrom the JWT payload alongside the existingidfollowLog.countfilter to usetargetUsername: usernameso the metric reflects how many other users have successfully followed the current usertotalFollowsfield name is preserved; its semantic is now correctTesting
totalFollowsreturns 0 when no one has followed the user, even if the user has followed many othersNotes
The JWT payload already includes
username(set in bothauthRoutesandconnectRoutesat sign time), so no auth changes are required.