✨ Feature :- Download Conference contract #212
Conversation
ahsanfarooq210
changed the title
There was a problem hiding this comment.
Hey @ahsanfarooq210,
thanks for the great work. It looks like the perfect scaffolding we needed to tailor this precisely to our needs while saving us a ton of time – and its just in time as well, because the postal registration for our second conference this year is about to start.
I think one little bug is that the wrong page is being cut out if the user is of age? In my PDF with an adult user I get Page 1, 2 and 4, but if I oversee it correctly, it should be 1, 3 and 4 right?
Also the page index skips the page, which is not ideal for legal documents since it gives the impression of a page missing. If it is too much effort determaining the page indices dynamically, I'd suggest to just index the 3rd and 4th page as 1 and 2 and omit the index from the other pages, since they are not necessarily connected documents.
src/routes/(authenticated)/dashboard/[conferenceId]/postalRegistration/+page.svelte
Outdated
Show resolved
Hide resolved
src/routes/(authenticated)/dashboard/[conferenceId]/postalRegistration/+page.svelte
Outdated
Show resolved
Hide resolved
|
Hi @Strehk. I have made the changes, Please review. |
| }); | ||
|
|
||
| yPosition -= 25; | ||
| this.page.drawText('Schleswig-Holstein', { |
There was a problem hiding this comment.
We probably should make this configurable
|
|
||
| // Add form title | ||
| yPosition -= 60; | ||
| this.page.drawText('Postalische Anmeldung MUN-SH 2025', { |
There was a problem hiding this comment.
Same for this. We at least should consider using paraglide strings for this
|
|
||
| // Add recipient address section | ||
| yPosition -= 30; | ||
| this.page.drawText('per Post zu senden an:', { |
| // Add consent text | ||
| yPosition -= 35; | ||
| const consentText = | ||
| 'im folgenden "Teilnehmende*r", das 18. Lebensjahr am 6. März 2025 noch nicht vollendet hat, erkläre(n) wir/ich uns/mich in meiner Funktion als Erziehungsberechtigte*r mit der Teilnahme des*der Teilnehmenden an MUN-SH 2025 einverstanden und akzeptiere(n) die beigefügten Vertragsbedingungen und die Datenschutzerklärung und in Vertretung von des*der Teilnehmenden.'; |
There was a problem hiding this comment.
here we additionally need variables for the Dates and the conference name
|
Looks very nice! Normally I don't really use classes in TS but I totally see why it makes sense here. I have a strange paraglide error on my dev machine right now and will continue the review once I get that fixed. Thanks a lot for yout work ahsan! |
|
Hey @ahsanfarooq210 we just spoke about this PR and how we want to finalize it and we came to the conclusion, that it might be a lot easier if we just tailor it to our specific needs from here on. That should be less overhead for you and we can directly integrate feedback that we get from our stakeholders. I hope that is okay for you? |
This pull request introduces a feature that enables users to download conference contracts directly from the application. The implementation includes generating PDF documents for conference contracts, allowing users to easily access and download them as needed.
Key Changes:
PDF Generation: Integrated functionality to create PDF versions of conference contracts.
Download Capability: Added a feature that allows users to download the generated PDF contracts.
These enhancements aim to improve user experience by providing a straightforward method for obtaining official conference documentation.