Repository navigation
fix(pipeline): infer HTTP method for Angular and verb-suffix client calls (#2768) - #2854
Open
divakantpandey wants to merge 1 commit into
Open
divakantpandey wants to merge 1 commit into
divakantpandey wants to merge 1 commit into
Conversation
…alls (DeusData#2768) Signed-off-by: Divakant Pandey <divakant01@gmail.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2768
Problem
Angular
HttpClientcalls (e.g.,this.http.get('/items/list'),this.http.get('/items/' + id)) were misclassified as server route registrations in unresolved service handling because receiver conventions (HttpClient,httpClient,this.http,this.httpClient,$http) and@angular/common/httpwere missing fromhttp_libraries. Furthermore,detect_url_in_args()unconditionally minted__route__ANY__without an HTTP method, causing cross-repo template matching to link GET requests to the first matching server route template regardless of HTTP verb (e.g. matchingDELETE /items/{id}orPOST /items/{parentId}/{id}).Solution
@angular/common/http,HttpClient,httpClient,this.http,this.httpClient, and$httptohttp_librariesinservice_patterns.c.cbm_service_pattern_matchbeforecalls_emit_route_callincalls_emit_unresolved_serviceto ensure client HTTP calls take precedence over route registration heuristics.cbm_service_pattern_http_method()indetect_url_in_args()and fallback to callee suffix inpass_route_nodes.candpass_cross_repo.c.test_pipeline.candtest_cross_repo.ccovering AngularHttpClientcalls in both parallel and sequential modes, and verifying exact verb matching against overlapping route templates.