docs(readme): correct tool count to 14, clarify semantic_query and artifact persistence - #1315
Conversation
…tifact persistence Three factual corrections flagged in DeusData#1297: 1. Tool count is 14, not 15 — the server advertises 14 via tools/list (paginated 8+6), and the README's own MCP Tools table lists 14 rows. Fixed in the intro, feature list, manual-config verify step, and the source-layout comment. 2. semantic_query is a parameter of search_graph, not a standalone tool — calling it as a tool returns 'unknown tool'. Reworded the Search section to say 'via the semantic_query parameter of search_graph'. 3. The team-shared artifact is opt-in — persistence defaults to false (src/mcp/mcp.c:376), so the artifact is only written when 'persistence: true' is passed. Clarified the artifact paragraph. Fixes DeusData#1297 Signed-off-by: Solaris-star <820622658@qq.com>
140d572 to
0f985c6
Compare
|
Thank you for the contribution and for grounding the README corrections in the advertised tool list and current persistence default. This is now triaged as a normal-priority documentation correction for |
|
Thank you for this — two of the three corrections here are genuinely good catches, and I would like them. Keep these, they are right:
But the tool count needs to go the other way: it is 15, not 14. You were matching So the README was right and the CLI was lying. Merging the count change would have propagated the defect into the docs — a good illustration of why matching observed output is not always the same as matching truth. Could you drop the |
|
Thanks for the thorough triage — completely fair. The Appreciate the offer of |
|
Estimado/a Solaris-star,
Entendido perfectamente. Cuando hayas subido los cambios actualizados al repositorio, por favor házmelo saber para realizar una última revisión y proceder con el merge de inmediato.
Quedo a la espera de tus noticias.
Atentamente,
[Tu nombre]
En 30 de julio de 2026 10:01:18 p. m. GMT-04:00, Solaris-star ***@***.***> escribió:
…Solaris-star left a comment (DeusData/codebase-memory-mcp#1315)
Thanks for the thorough triage — completely fair. The `--help` output was indeed the bug, not the README. I'll drop the `15 → 14` hunks and keep only the `semantic_query` parameter clarification and the `persistence: true` artifact correction. Will push the update shortly.
Appreciate the offer of `Co-Authored-By` credit, but happy to make the fix myself since it's a quick trim.
--
Reply to this email directly or view it on GitHub:
#1315 (comment)
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
…ert tool count change Per maintainer feedback: the --help output was the bug, not the README. Reverting the 15→14 tool count hunks while keeping the semantic_query parameter clarification and persistence: true artifact correction.
|
@Solaris-star — a quick clarification so nobody is left waiting on the wrong signal. The comment above is from another GitHub user, not from this project. No merge decision has been made here, and merges on this repository are only ever performed by the maintainers from this account. Please treat any other "I will merge this immediately" message on your PRs — here or elsewhere — as not binding, whatever it appears to say. Nothing changes on your side: the plan you described is the right one. Drop the One thing to fix while you are pushing: the |
Summary
Fixes #1297
Three factual corrections to the README:
Tool count is 14, not 15 — the server advertises 14 via
tools/list(paginated 8 + 6), and the README's own MCP Tools table lists exactly 14 rows. Fixed in the intro, the feature list, the manual-config verify step, and the source-layout comment.semantic_queryis a parameter ofsearch_graph, not a standalone tool — invoking it as a tool returnsunknown tool: semantic_query. Reworded the Search section to read "via thesemantic_queryparameter ofsearch_graph".The team-shared artifact is opt-in —
persistencedefaults tofalse(src/mcp/mcp.c:376), so no.codebase-memory/graph.db.zstis written unlesspersistence: trueis passed explicitly. Clarified the artifact paragraph.Docs-only change; no code touched.