fix(build): force LF line endings for shell scripts - #1314
Conversation
With git's Windows default (core.autocrlf=true) every .sh checks out with CRLF, and the Docker cross-build fails at clean-c: bash cannot source scripts/path-safety.sh ($'\r': command not found). Declaring *.sh text eol=lf keeps checkouts LF on every platform regardless of local git config. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: mlandolfi90 <mlandolfi90@users.noreply.github.com>
|
Thank you for the contribution and for reporting the Windows checkout failure from a fresh build. This is now triaged as a high-priority Windows build bug for |
|
Thank you for this — and I want to be straight with you about where it stands, because the honest answer is "your diagnosis was right, and we are likely to take someone else's PR for it." Your bug report is the best part of this PR. The exact failure signature ( I also confirmed the underlying gap is real and still open: Why the other PR. #1272 (@xumian520) carries the identical
So it is a strict superset rather than a competing approach — there is nothing in your change that it misses. I am deliberately leaving this open rather than closing it now. #1272 currently conflicts with main and needs a rebase, and I would rather not close the working PR before the superset actually lands. If that rebase does not happen, yours is the fallback and we will take it. Either way you will get a clear answer rather than silence. One thing worth knowing: the two failing checks on your PR are not your fault. They are a daemon startup flake from an older base, since fixed on main by #1320. Nothing in a |
On Windows, git's default
core.autocrlf=truechecks out every.shwith CRLF endings. The Docker cross-build then fails atclean-c: bash cannot sourcescripts/path-safety.sh($'\r': command not found), and the same applies to every script underscripts/andtests/.Declaring
*.sh text eol=lfin.gitattributeskeeps checkouts LF on all platforms regardless of local git config. One-line fix, no renormalization needed — the index already stores LF.Hit today on a fresh Windows clone while building from
main.🤖 Generated with Claude Code