Skip to content

Add bulk update triage, suppress and unsuppress. #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

axeny840
Copy link

Description

Addressed Issue

Additional Details

Checklist

@Copilot Copilot AI review requested due to automatic review settings May 19, 2025 12:12
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a bulk update feature for vulnerability triage, including the ability to suppress and unsuppress across multiple projects. Key changes include:

  • A new BulkUpdateModal component to gather bulk analysis inputs.
  • Updated AffectedProjects.vue to add buttons for bulk-update, suppress, and unsuppress, plus handling logic.
  • New i18n keys for bulk update messages and UI text, plus minor Docker and issue-template updates.

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/views/portfolio/vulnerabilities/BulkUpdateModal.vue Added modal template and logic for bulk vulnerability updates
src/views/portfolio/vulnerabilities/AffectedProjects.vue Added bulk-update, suppress/unsuppress buttons and handlers
src/i18n/locales/*.json Added translations for bulk_update, no_projects_selected, projects_selected, unsuppress
docker/Dockerfile.alpine Updated the nginx-unprivileged image SHA
.github/ISSUE_TEMPLATE/defect-report.yml Added 4.13.2 to supported versions list
Comments suppressed due to low confidence (6)

src/views/portfolio/vulnerabilities/AffectedProjects.vue:95

  • [nitpick] The field name 'state' for the checkbox column is ambiguous. Rename it to something like 'selected' to clarify its purpose.
field: 'state',

src/views/portfolio/vulnerabilities/BulkUpdateModal.vue:121

  • The data property isSuppressed references this.finding, which is not defined or passed into this component. Consider accepting a finding prop or initializing isSuppressed differently.
isSuppressed: !!this.finding?.analysis?.isSuppressed,

src/views/portfolio/vulnerabilities/BulkUpdateModal.vue:54

  • [nitpick] Inconsistent use of this.$t vs $t in templates; for clarity and consistency, choose one style throughout the component.
:label="this.$t('message.response')"

src/views/portfolio/vulnerabilities/AffectedProjects.vue:54

  • The refreshTable event binding on <bulk-update-modal> is not used (the modal never emits this event). You can remove this unused listener.
v-on:refreshTable="refreshTable"

src/views/portfolio/vulnerabilities/AffectedProjects.vue:200

  • Calling callRestEndpoint inside nested loops will generate many sequential network requests. Consider batching requests or processing them concurrently to improve performance.
this.callRestEndpoint(

src/views/portfolio/vulnerabilities/AffectedProjects.vue:312

  • [nitpick] The error handler shows a generic warning only. Consider logging the error object or displaying more detailed feedback to help with debugging.
this.$toastr.w(this.$t('condition.unsuccessful_action'));

@owasp-dt-bot
Copy link

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants