Skip to content

1.21.5 Item/NBT cleanups #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2025
Merged

1.21.5 Item/NBT cleanups #2723

merged 1 commit into from
May 3, 2025

Conversation

tal5
Copy link
Member

@tal5 tal5 commented May 2, 2025

Changes

  • ItemHelper#get/setShieldColor now uses the ShieldMeta API on 1.21+, and has TODOs for future cleanups.
  • Removed the 1.21 impl of ItemHelper#get/setShieldColor ^.
  • Removed/Added some 1.21 TODO comments where needed.

@tal5 tal5 merged commit db9d638 into DenizenScript:dev May 3, 2025
1 check passed
@tal5 tal5 deleted the NBT_Cleanups branch May 3, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmonkey4eva mcmonkey4eva mcmonkey4eva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tal5 @mcmonkey4eva