1.21.5 Area effect cloud fixes
#2722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmonkey4eva
previously approved these changes
May 3, 2025
mcmonkey4eva
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
EntityAreaEffectCloudis now registered on all versions again.EntityAreaEffectCloudfor some of the extra work that needs to be done there.EntityTag.base_potion& sub-tags on 1.20+ in favor of adding area effect clouds toEntityTag.potion_type.EntityTag.particle.color&EntityTag.particle_colormech in favor of adding area effect clouds toEntityTag.color.EntityTag.has_custom_effect,custom_effects,clear_custom_effectsmech,remove_custom_effectmech, andcustom_effectsmech, in favor of adding area effect clouds toEntityPotionEffectswith all of its tags and mechs.EntityTag.base_potionmech on 1.20+ in favor ofEntityTag.potion_type, and gave it some minor code updates, mostly for backsupport on modern versions.EntityTag.particle, as it technically works for now but is missing particle data input, causing some particles to be impossible to set.AreaEffectCloudHelper#setParticlenow usesUtilitiesmethods to allow older particle names as input.