Replace Bleach with NH3 #2505
Merged
Replace Bleach with NH3 #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awdem
reviewed
Mar 31, 2025
ynr/apps/moderation_queue/views.py
Outdated
| ) | ||
| # before linkifying any URLs:. | ||
| context["justification_for_use"] = urlize( | ||
| nh3.clean(self.queued_image.justification_for_use) |
There was a problem hiding this comment.
Does nh3.clean() default to stripping the html tags? It looks like we had to pass strip=True to bleach.clean().
There was a problem hiding this comment.
Yeah good catch. I assumed not passing an allowlist would strip all tags, but I've pushed a commit to allow a tags and nothing else.
There was a problem hiding this comment.
Yeah that looks like it does the trick.
awdem
approved these changes
Mar 31, 2025
awdem
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.