Message highlights #2990
Draft
Message highlights #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add text highlighting (cherry picked from commit e442cc4bb20fbb4d5b970275c82cc87508e6f687)
Edge case that's not handled: Closing and reopening the game drops the list of auto-generated highlights
github-actions
bot
added
S: Needs Review
size/L
Since the implementation is now fundamentally incompatible with the (still open) upstream PR, move to our own cvars
|
Holy peak |
deltanedas
requested changes
Feb 18, 2025
Content.Client/UserInterface/Systems/Chat/Controls/ChannelFilterPopup.xaml.cs
Show resolved
Hide resolved
Content.Client/UserInterface/Systems/Chat/Controls/ChannelFilterPopup.xaml
Outdated
Show resolved
Hide resolved
github-actions
bot
added
size/XL
deltanedas
requested changes
Feb 18, 2025
Content.Client/UserInterface/Systems/Chat/Controls/ChannelFilterPopup.xaml.cs
Outdated
Show resolved
Hide resolved
Content.Client/UserInterface/Systems/Chat/Widgets/ChatBox.xaml.cs
Outdated
Show resolved
Hide resolved
Content.Client/_DV/UserInterfaces/Systems/Chat/ChatUIController.cs
Outdated
Show resolved
Hide resolved
deltanedas
previously approved these changes
Feb 18, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
If I'm already touching this with more fixes again |
auto-merge was automatically disabled
February 18, 2025 22:30
Head branch was pushed to by a user without write access
|
Okay so I can't figure out why exactly or what to do about it, but the error is caused by |
|
Fuck |
Toby222
force-pushed
the
message-highlights
branch
from
4641f0a to
57a396f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Ported message highlighting from impstation/imp-station-14#468 and space-wizards/space-station-14#31442
Why / Balance
ADHD :)
Chat is hard to follow a bunch of the time, and finding relevant information at a glance is hard
Technical details
For auto-highlighting, uses your job's name for fetching what terms to highlight
Auto-highlighted strings are not persistent and only depend on your character
Media
Requirements
Breaking changes
Adds three new Client CVars
Changelog
🆑