Skip to content

fix camelcase type definitions #8191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2016
Merged

fix camelcase type definitions #8191

merged 1 commit into from
Feb 22, 2016

Conversation

SamVerschueren
Copy link
Contributor

The previous camelcase definitions where not correct as export default assumes a default property in the exported object. Fixed by these changes.

Also added empty namespace because of microsoft/TypeScript#5073.

@sindresorhus Can you 👍 for me?

@dt-bot
Copy link
Member

dt-bot commented Feb 20, 2016

camelcase/camelcase.d.ts

to author (@SamVerschueren). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@SamVerschueren
Copy link
Contributor Author

Probably because I'm a contributor to camelcase, a 👍 from me will do?

@sindresorhus
Copy link
Contributor

👍

horiuchi added a commit that referenced this pull request Feb 22, 2016
@horiuchi horiuchi merged commit e7b1fbc into DefinitelyTyped:master Feb 22, 2016
@horiuchi
Copy link
Member

@SamVerschueren Thanks mate!
@sindresorhus Thanks for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants