Skip to content

CI: fix TypedArray/ArrayBuffer errors for TS 5.9 #72069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Renegade334
Copy link
Contributor

A specific changeset for breakage related to microsoft/TypeScript#60150 and unrelated to @types/node's Buffer.

Test-only changes:

  • akamai-edgeworkers: erroneous use of TypedArray where ArrayBuffer expected
  • chrome-apps: erroneous use of TypedArray where ArrayBuffer expected
  • node-forge: implementation specifically only accepts views on ArrayBuffer rather than ArrayBufferLike, so a test variable type needs to be Uint8Array<ArrayBuffer> rather than Uint8Array

Definition changes:

  • node-wav: use of ArrayBuffer where TypedArray was intended; in fact, the implementation just requires an array-like object here

@Renegade334 Renegade334 force-pushed the arraybuffer-assignability-fixes branch from 46aace6 to 8ac4ddb Compare February 27, 2025 17:09
@Renegade334 Renegade334 marked this pull request as ready for review February 27, 2025 17:13
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 27, 2025

@Renegade334 Thank you for submitting this PR!

This is a live comment that I will keep updated.

4 packages in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes that affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 72069,
  "author": "Renegade334",
  "headCommitOid": "8ac4ddb5d4381ed0d74d03b69ff022996bd85a59",
  "mergeBaseOid": "450c386d5755adba90d899086d4b4f5e142e322b",
  "lastPushDate": "2025-02-27T17:02:00.000Z",
  "lastActivityDate": "2025-02-27T18:31:25.000Z",
  "mergeOfferDate": "2025-02-27T18:26:08.000Z",
  "mergeRequestDate": "2025-02-27T18:31:25.000Z",
  "mergeRequestUser": "Renegade334",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "akamai-edgeworkers",
      "kind": "edit",
      "files": [
        {
          "path": "types/akamai-edgeworkers/test/crypto.ts",
          "kind": "test"
        },
        {
          "path": "types/akamai-edgeworkers/test/scenario-crypto.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "evan-hughes",
        "wabain",
        "swathimr",
        "ananner",
        "bmatthew"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "chrome-apps",
      "kind": "edit",
      "files": [
        {
          "path": "types/chrome-apps/test/index.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "niikoo",
        "AdamLay",
        "mzsm",
        "RReverser",
        "pyle",
        "matthewkimber",
        "otiai10",
        "rreverser",
        "sreimer15"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "node-forge",
      "kind": "edit",
      "files": [
        {
          "path": "types/node-forge/node-forge-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "westy92",
        "flynetworks",
        "a-k-g",
        "rafal2228",
        "beenotung",
        "joeflateau",
        "timhwang21",
        "andersk",
        "saschazar21",
        "rogierschouten",
        "aseevia",
        "wiktor-k",
        "frangello",
        "avezov",
        "j-fuentes",
        "darkade",
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "node-wav",
      "kind": "edit",
      "files": [
        {
          "path": "types/node-wav/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jameswilddev"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2025-02-27T18:25:27.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2688603390,
  "ciResult": "pass"
}

@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Review in Pull Request Status Board Feb 27, 2025
@typescript-bot
Copy link
Contributor

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Feb 27, 2025
@typescript-bot
Copy link
Contributor

@Renegade334: Everything looks good here. I am ready to merge this PR (at 8ac4ddb) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in Pull Request Status Board Feb 27, 2025
@Renegade334
Copy link
Contributor Author

Ready to merge.

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Feb 27, 2025
@typescript-bot typescript-bot merged commit c58b80e into DefinitelyTyped:master Feb 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Edits multiple packages Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants