Skip to content

ramda: Allow currying of type guards #17097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2017
Merged

Conversation

sbking
Copy link
Contributor

@sbking sbking commented Jun 9, 2017

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@dt-bot
Copy link
Member

dt-bot commented Jun 9, 2017

types/ramda/index.d.ts

to authors (@donnut @mdekrey @LiamGoodacre @mrdziuban). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?


let drive = function(fastCar: FastCar) {};

let cars: Car[] = [{ speed: 65 }, {}];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use const for all of these variables since they remain unchanged

@sbking
Copy link
Contributor Author

sbking commented Jun 10, 2017

@mrdziuban Thanks, fixed and squashed!

@mrdziuban
Copy link
Contributor

Thanks! LGTM, though I'm not sure what the policy is on merging since I don't have write access.

@sbking
Copy link
Contributor Author

sbking commented Jun 10, 2017

@mrdziuban I'm not sure if you're supposed to thumbs up the original PR comment or the dt-bot comment, but I'm pretty sure once those are thumbs up'd it flags the PR for merging.

Or maybe you put a thumbs up in one of your own comments?

Copy link
Contributor

@mrdziuban mrdziuban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrdziuban
Copy link
Contributor

Okay, I did all of the above, plus approved it, hopefully it amounts to something

@mdekrey
Copy link
Contributor

mdekrey commented Jun 10, 2017

👍 to me too.

@yuit yuit merged commit a4eed08 into DefinitelyTyped:master Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants