Skip to content

Update gauntlet.ts #4402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2025
Merged

Update gauntlet.ts #4402

merged 3 commits into from
Oct 11, 2025

Conversation

@Roni-1997
Copy link
Contributor

@Roni-1997 Roni-1997 commented Oct 9, 2025

No fee capping and adding new vaults

@Roni-1997
Update gauntlet.ts
852c685 
Adding new vaults and removing negative fee capping
@llamabutler
Copy link

llamabutler commented Oct 9, 2025

The gauntlet.ts adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees gauntlet.ts

🦙 Running GAUNTLET.TS adapter 🦙
---------------------------------------------------
Start Date:	Wed, 08 Oct 2025 17:32:46 GMT
End Date:	Thu, 09 Oct 2025 17:32:46 GMT
---------------------------------------------------

Error: Request failed with status code 401
    at _queryDune (/home/runner/work/dimension-adapters/dimension-adapters/helpers/dune.ts:219:22)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async fetchSolana (/home/runner/work/dimension-adapters/dimension-adapters/fees/gauntlet.ts:139:27)
    at async getChainResult (/home/runner/work/dimension-adapters/dimension-adapters/adapters/utils/runAdapter.ts:220:18)
    at async Promise.all (index 3)
    at async _runAdapter (/home/runner/work/dimension-adapters/dimension-adapters/adapters/utils/runAdapter.ts:173:20)
    at async /home/runner/work/dimension-adapters/dimension-adapters/cli/testAdapter.ts:69:24 {
  axiosError: 'Dune API Key is invalid',
  chain: 'solana'
}

@treeoflife2 treeoflife2 self-requested a review October 10, 2025 11:27
treeoflife2
treeoflife2 reviewed Oct 10, 2025
View reviewed changes
fees/gauntlet.ts Outdated
SupplySideRevenue: {
[METRIC.ASSETS_YIELDS]: "Amount of yields distributed to supply-side depositors.",
},
Revenue: "Daily performance fees claimed by the Gauntlet manager during the specified time period"
Copy link
Member

@treeoflife2 treeoflife2 Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please merge upstream master branch, as you are overwriting many new implementation like breakdownmethodology.

treeoflife2
treeoflife2 requested changes Oct 10, 2025
View reviewed changes
Copy link
Member

@treeoflife2 treeoflife2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@treeoflife2 treeoflife2 self-assigned this Oct 10, 2025
@Roni-1997
Merge remote-tracking branch 'upstream/master' into patch-2
6bb4ce1
@Roni-1997
Merge upstream master and update adapter structure
c8d1ff3 
- Added METRIC imports and Dependencies for upstream compatibility
- Updated to version 1 adapter with breakdownMethodology structure
- Added proper METRIC.MANAGEMENT_FEES and METRIC.ASSETS_YIELDS usage
- Preserved new vaults: wETH Plus and dfdvSOL Plus
- Maintained negative fee support (no capping) to avoid double-counting
- Fixed double-counting by excluding manager fees from gross returns
- Added proper filtering for zero/null amounts in manager fees query

Addresses reviewer feedback about missing breakdownMethodology implementation.
@llamabutler
Copy link

llamabutler commented Oct 10, 2025

The gauntlet.ts adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees gauntlet.ts

🦙 Running GAUNTLET.TS adapter 🦙
---------------------------------------------------
Start Date:	Thu, 09 Oct 2025 00:00:00 GMT
End Date:	Fri, 10 Oct 2025 00:00:00 GMT
---------------------------------------------------

Error: Request failed with status code 401
    at _queryDune (/home/runner/work/dimension-adapters/dimension-adapters/helpers/dune.ts:219:22)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async fetchSolana (/home/runner/work/dimension-adapters/dimension-adapters/fees/gauntlet.ts:153:27)
    at async getChainResult (/home/runner/work/dimension-adapters/dimension-adapters/adapters/utils/runAdapter.ts:218:18)
    at async Promise.all (index 3)
    at async _runAdapter (/home/runner/work/dimension-adapters/dimension-adapters/adapters/utils/runAdapter.ts:173:20)
    at async /home/runner/work/dimension-adapters/dimension-adapters/cli/testAdapter.ts:69:24 {
  axiosError: 'Dune API Key is invalid',
  chain: 'solana'
}

@treeoflife2 treeoflife2 merged commit 89b4e81 into DefiLlama:master Oct 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@treeoflife2 treeoflife2 treeoflife2 requested changes

Assignees

@treeoflife2 treeoflife2

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Roni-1997 @llamabutler @treeoflife2