-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feature: update fee data source #4393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: update fee data source #4393
Conversation
|
The pumpup.ts adapter exports: |
|
The pumpup.ts adapter exports: |
|
@crispyfisherman what was exactly wrong, and why shouldn't we keep it onchain? is there any logic offchain? |
Hi @treeoflife2, our previous data didn’t include all of the tokens we support, so the fee data results were inaccurate Our fee data is actually fetched directly from on-chain sources by our indexer, without any additional logic. We also display the protocol’s revenue data on our website Switching to an API is simply to ensure that the data on our site and on DeFiLlama remain as closely aligned as possible |
|
@crispyfisherman can you create separate fees adapter for doubleupsports.com as that's prediction market. as we will conver the https://www.doubleup.fun/ to casino instead of prediction market. |
@treeoflife2, thanks for merging the commit! Sorry, could you clarify what you mean by a separate fees adapter for DoubleUpSports? Do you have an example? Also, we just noticed that DoubleUp is listed under “Luck Games” on the Sui protocol ranking list, but it still shows as “Prediction Market” on our protocol page
What category does DoubleUp currently belong to? And what’s the difference between the “Casino,” “Luck Games,” and “Gaming” categories? |
you have two separate products so i suggest we would need two listing, one for prediction market(sports bets)(https://www.doubleupsports.com/) and another for casino games(https://www.doubleup.fun/)
maybe cache issue, but you will need to create new listing for prediction market, and correct TVLs and separate fee and revenue adapter as both are separate category.
we don't have any casino category, so doubleup.fun will be listed as luck games, and gaming category for projects like (axie infinity) |
|
@treeoflife2, I see So our product would be like this way?
Under doubleup will have two items DoubleUp |



Hi, we’re the DoubleUp team. We’d like to update our Fee and Revenue data.
Also, our previous fee data was inaccurate — how can we update the historical data as well?