Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fee Adapter for total fees for LogX #2534

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Fee Adapter for total fees for LogX #2534

wants to merge 3 commits into from

Conversation

snehilms
Copy link

No description provided.

@llamabutler
Copy link

The logx adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees logx

🦙 Running LOGX adapter 🦙
---------------------------------------------------
Start Date:	Tue, 11 Mar 2025 00:00:00 GMT
End Date:	Wed, 12 Mar 2025 00:00:00 GMT
---------------------------------------------------

ARBITRUM 👇
Backfill start time: 11/9/2024
Total fees: 2.04 M

@llamabutler
Copy link

The logx adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees logx

🦙 Running LOGX adapter 🦙
---------------------------------------------------
Start Date:	Tue, 11 Mar 2025 00:00:00 GMT
End Date:	Wed, 12 Mar 2025 00:00:00 GMT
---------------------------------------------------

LOGX_NETWORK 👇
Backfill start time: 11/9/2024
Total fees: 2.04 M

dtmkeng
dtmkeng requested changes Mar 12, 2025
View reviewed changes
fees/logx/index.ts Outdated
).toString();

return {
totalFees: totalFees,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add dailyVolume

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have adaptor for that here which was merged
https://github.com/DefiLlama/dimension-adapters/blob/master/dexs/logx/index.ts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I mean dailyFees

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you handle washtrading already ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing wash trading is crucial for data accuracy.
Currently, the adapter does not filter out wash trading.

Copy link
Author

@snehilms snehilms Mar 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To prevent wash trading and ensure fair trading practices, we have implemented the following measures:

  1. Reward Slashing – Any rewards linked to wash trading are automatically slashed, thereby disincentivizing users against manipulation.

  2. Solver-Based Liquidity Aggregation – Our solver model sources liquidity from top centralized exchanges and applies a 0.05% fee on every order (limit or market both). Therefore like traditional orderbooks where users can take market and limit orders both side to wash trade, in LogX it is not possible to do it without paying fees to the platform hence making wash trading impractical.

  3. Fee Redistribution – All net fees are redistributed to stakers via a buyback and distribute mechanism. More details: Buyback Machine.

Let us know if any additional details are needed to get this through.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added daily fees as well @0xy0k

@llamabutler
Copy link

The logx adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees logx

🦙 Running LOGX adapter 🦙
---------------------------------------------------
Start Date:	Wed, 12 Mar 2025 00:00:00 GMT
End Date:	Thu, 13 Mar 2025 00:00:00 GMT
---------------------------------------------------

LOGX_NETWORK 👇
Backfill start time: 11/9/2024
Total fees: 2.05 M
Daily fees: 10.72 k
End timestamp: 1741737600 (2025-03-12T00:00:00.000Z)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtmkeng dtmkeng dtmkeng requested changes

@0xy0k 0xy0k 0xy0k left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snehilms @llamabutler @dtmkeng @0xy0k