Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added sui & stellar #14123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

benjamin852
Copy link
Contributor

NOTE

Please enable "Allow edits by maintainers" while putting up the PR.


  • If you would like to add a volume adapter please submit the PR here.
  • If you would like to add a liquidations adapter, please refer to this readme document for details.
  1. Once your adapter has been merged, it takes time to show on the UI. If more than 24 hours have passed, please let us know in Discord.
  2. Sorry, We no longer accept fetch adapter for new projects, we prefer the tvl to computed from blockchain data, if you have trouble with creating a the adapter, please hop onto our discord, we are happy to assist you.
  3. Please fill the form below only if the PR is for listing a new protocol else it can be ignored/replaced with reason/details about the PR
  4. For updating listing info It is a different repo, you can find your listing in this file: https://github.com/DefiLlama/defillama-server/blob/master/defi/src/protocols/data2.ts, you can edit it there and put up a PR
  5. Do not edit/push package-lock.json file as part of your changes, we use lockfileVersion 2, and most use v1 and using that messes up our CI
  6. No need to go to our discord and announce that you've created a PR, we monitor all PRs and will review it asap

Name (to be shown on DefiLlama):
Twitter Link:
List of audit links if any:
Website Link:
Logo (High resolution, will be shown with rounded borders):
Current TVL:
Treasury Addresses (if the protocol has treasury)
Chain:
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama):
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one:
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):

@waynebruce0x
Copy link
Collaborator

Error in sui: Error: [sui] Invalid params

@waynebruce0x waynebruce0x self-assigned this Apr 1, 2025
@waynebruce0x
Copy link
Collaborator

still same error - do you see this when testing locally?

@benjamin852
Copy link
Contributor Author

benjamin852 commented Apr 4, 2025

Hey @waynebruce0x I think it's due to lack of assets on sui being indexed (as the integration is brand new still). As a result one of the sui api calls (i believe it was suix_getAllBalances()) fails as their is no owner being passed into the required param. I will revisit this to try unblock, thanks.

Copy link
Member

@g1nt0ki g1nt0ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wont work since neither sui not stellar is an evm chain, we need custom tvl adapter for each, can you share the contract address where tokens are locked in these chains?

@benjamin852
Copy link
Contributor Author

Thanks for taking a look @g1nt0ki!

Would the helper files for each of those chains though not resolve this? (for example for sui I saw this helper file was being called when I tested).

Regarding key contracts there will probably be more over time but for now I'd say let's focus on the Gateway contract for each of those chains

Sui: 0xeb055ffc3237c24e305a2bb760fe6551f6ff7c5fdb68735169c0f528fccab373
Stellar: CD6VSKXB4HY2DWU7EP2PUIYTBJBJ36LDJXEZN4NSXFYF5YP37DDFX6NF

Thanks!

@g1nt0ki
Copy link
Member

g1nt0ki commented Apr 9, 2025

hi @benjamin852 can you instead share the addresses where the tokens are locked on sui & stellar, not sure what to do with the contract you have shared 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants