Apply the note visibility rule in the note UI views - #15660
Open
svader0 wants to merge 1 commit into
Open
Conversation
The read paths go through the notes visibility helper. The three views under dojo/notes/ui share a prologue that resolves the note and its parent object, so the same rule now applies there, covering all three views and all three page types in one place. The edit form no longer offers the visibility field to a requester who did not write the note. The edit view built its form in four branches. That is now one. Adds tests for the three views, once per page type. There were none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening / consistency improvement to the note views under
dojo/notes/ui.The notes read paths go through the visibility helper. The three views there share a prologue that resolves the note and its parent object, so the same rule is applied in that one place, which covers all three views and all three page types.
The edit form no longer offers the visibility field to a requester who did not write the note. The edit view built its form in four branches; that is now one.
Adds regression tests for the three views, once per page type. There were none before.
No functional change for correctly-permissioned users.