Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tab to "Show Password" within Login Page #11812

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

kevin-vuong99
Copy link
Contributor

Description

If a user is using only the keyboard, they are not able to tab on "Show Password" within the login page.

Impact on users

People who are blind (who cannot use devices such as mice that require eye-hand coordination).
People with low vision (who may have trouble finding or tracking a pointer indicator on screen).
Some people with hand tremors find using a mouse very difficult and therefore usually use a keyboard.

Steps to reproduce

When you start tabbing within the login page, from the top (URL), Focus goes to Username and then password, and then Login, bypassing show Password.

Remediation

Have the "Show Password" keyboard operable by allowing tabbing on the element to be gained.

Image below shows "Show Password" being tabbed over:
image

Instead of just using the div tag and text, I've added a button since it supports tabbing with a keyboard. I added a CSS id selector and rules to match the previous look of the page. The bold tags for "Show Password" were also moved to the CSS rule block.

@github-actions github-actions bot added the ui label Feb 12, 2025
@kevin-vuong99 kevin-vuong99 marked this pull request as ready for review February 12, 2025 20:39
Copy link

DryRun Security Summary

The pull request implements password visibility toggle functionality in the login form with UI updates across multiple file types while maintaining security standards.

Expand for full summary

The pull request modifies the login form's password visibility toggle across JavaScript, HTML, and CSS files, introducing minor UI and styling changes. No security vulnerabilities were found in the reviewed files.

Code Analysis

We ran 9 analyzers against 3 files and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Configured Codepaths Analyzer 1 finding

Overall Riskiness

🔴 Risk threshold exceeded.

We've notified @mtesauro, @grendel513.

View PR in the DryRun Dashboard.

@kevin-vuong99 kevin-vuong99 changed the title Allow tab to "Show Password" Allow tab to "Show Password" within Login Page Feb 12, 2025
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants