Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff: Add and fix PLW0604 #11773

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Ruff: Add and fix PLW0604 #11773

wants to merge 1 commit into from
+5 −8

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Feb 9, 2025

By using memoization, ugly global can be removed and fix global-at-module-level (PLW0604)

@kiblik kiblik marked this pull request as ready for review February 9, 2025 14:55
@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Feb 9, 2025 •
edited
Loading

DryRun Security Summary

The PR updates Ruff's linting configuration with security-focused rules and modifies the test framework's caching mechanism, addressing potential security considerations around cache persistence and sensitive data handling.

Expand for full summary

PR updates Ruff linting configuration and refactors test framework caching mechanism. Security findings:

  1. In ruff.toml: Potential security observation that while no direct vulnerabilities exist, the configuration includes security-focused linting rules (S1, S2, S302-S610)

  2. In unittests/test_rest_framework.py: Potential cache-related security consideration with @functools.cache - ensure cache doesn't persist or become stale with sensitive information

Code Analysis

We ran 9 analyzers against 2 files and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

mtesauro
mtesauro approved these changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtesauro mtesauro mtesauro approved these changes

@dogboat dogboat dogboat approved these changes

@Maffooch Maffooch Maffooch approved these changes

At least 4 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
lint unittests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiblik @mtesauro @dogboat @Maffooch