Skip to content

[Ascend] fix sub bug for ascend #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[Ascend] fix sub bug for ascend #905

wants to merge 6 commits into from

Conversation

@jingguo-st
Copy link
Collaborator

@jingguo-st jingguo-st commented Jul 19, 2024 •
edited
Loading

Motivation

bugfix for ascend:

  1. sub segment scenario: 2 - x.dipu()
  2. alpha dtype check in rsub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhangzefeng92 zhangzefeng92 zhangzefeng92 approved these changes

@mrdanielw mrdanielw Awaiting requested review from mrdanielw mrdanielw is a code owner

@lljbash lljbash Awaiting requested review from lljbash lljbash is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jingguo-st @zhangzefeng92