Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(dipu): partially clean cmake #883

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

refactor(dipu): partially clean cmake #883

wants to merge 5 commits into from

Conversation

wiryls
Copy link
Collaborator

@wiryls wiryls commented Jul 8, 2024 •
edited
Loading

这个 PR 是以前的 #646 的拆分和延续，主要包含部分 CMake 脚本重构：

  1. 将部分变量移到 cmake 脚本之外
  2. 删除一些不再使用的、或者没有效果的变量定义
  3. 重命名部分变量
  4. 将部分设置、属性从全局的，修改为 target 的

@wiryls wiryls added DIPU DIPU related refactor just better coding labels Jul 8, 2024
@wiryls wiryls changed the title refactor(dipu): partially clean cmake, and move torch version detection from cmake to cpp header refactor(dipu): partially clean cmake Jul 16, 2024
zhangzefeng92 pushed a commit to DeepLink-org/deeplink.framework.dev that referenced this pull request Jul 18, 2024
@lwj-st
add kunlunxin coverage (DeepLink-org#883)
d93a310 
add kunlunxin coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdanielw mrdanielw Awaiting requested review from mrdanielw mrdanielw is a code owner

@lljbash lljbash Awaiting requested review from lljbash lljbash is a code owner

@Wrench-Git Wrench-Git Awaiting requested review from Wrench-Git Wrench-Git is a code owner

@fandaoyi fandaoyi Awaiting requested review from fandaoyi

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
DIPU DIPU related refactor just better coding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wiryls