Zq/add specified autocompare2 #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lingjie <[email protected]>
NeosZhang
requested review from
mrdanielw,
lljbash,
wiryls,
Wrench-Git and
wugeshui
as code owners
lljbash
approved these changes
Apr 26, 2024
| @@ -2770,6 +2768,7 @@ | |||
|
|
|||
| - schema: _amp_foreach_non_finite_check_and_unscale_(at::TensorList self, Tensor(b!) found_inf, Tensor inv_scale) -> void | |||
| autocompare: disable | |||
| # TODO(someone): fix this issue when `autocompare` is on | |||
There was a problem hiding this comment.
done，后面我来跟进这个issue
| [&opname](auto& matcher) { return std::regex_match(opname, matcher); }); | ||
| } | ||
|
|
||
| constexpr const char* fallbackEnvName = "DIPU_FORCE_FALLBACK_OPS_LIST"; |
There was a problem hiding this comment.
Suggested change
| constexpr const char* fallbackEnvName = "DIPU_FORCE_FALLBACK_OPS_LIST"; | |
| constexpr const char* kFallbackEnvName = "DIPU_FORCE_FALLBACK_OPS_LIST"; |
下同
lljbash
approved these changes
Apr 26, 2024
zhaoguochun1995
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
基于这个PR进行修改，原来的PR保留为draft。
重构register机制，针对配置文件中的custom_fallback和autocmpare，定义了四个注册宏
生成的代码片段如下：