Skip to content

Zq/fix nll loss v2 #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Zq/fix nll loss v2 #1330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
552490f
impl cel and nll_loss2 for ascend
jingguo-st Jul 31, 2024
92205cb
fix nll_loss
Jul 31, 2024
78df3ed
fix
Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions diopi_test/python/conformance/diopi_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,6 +947,8 @@ def cross_entropy(
weight = weight
else:
weight = None

totalWeight = Tensor((1,), input.get_dtype())

sizeI = input.size().data
sizeO = [sizeI[0]] + sizeI[2:]
Expand All @@ -956,7 +958,7 @@ def cross_entropy(
out = Tensor((), input.get_dtype())

reduction_mode = convert_reduction(reduction)
func = check_function("diopiCrossEntropyLoss")
func = check_function("diopiCrossEntropyLossWithTotalWeight")
ret = func(
input.context(),
out,
Expand All @@ -968,6 +970,7 @@ def cross_entropy(
label_smoothing,
)
check_returncode(ret)
GLOBAL_STATE["cross_entropy_totalWeight"] = totalWeight
return out


Expand Down Expand Up @@ -4640,9 +4643,11 @@ def cross_entropy_backward(
weight = weight
else:
weight = None

totalWeight = GLOBAL_STATE.pop("cross_entropy_totalWeight")

reduction_mode = convert_reduction(reduction)
func = check_function("diopiCrossEntropyLossBackward")
func = check_function("diopiCrossEntropyLossWithTotalWeightBackward")
ret = func(
input.context(),
grad_input,
Expand Down
8 changes: 8 additions & 0 deletions impl/ascend/convert_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,3 +479,11 @@
- diopiMaxPool2dBackward:
tensor_dtype:
indices: (int64)->int32

- diopiCrossEntropyLossWithTotalWeight:
dtype: (float64)->float32
layout: ND

- diopiCrossEntropyLossWithTotalWeightBackward:
dtype: (float64)->float32
layout: ND
Loading