Update header dynamically #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know but as I have said in the PR, for some reason the notify: true on the header property doesn't fire the header-changed event! I'm doing it manually with this.fire... Do you have a solution ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
First, thx for your component, it helps us a lot.
We use an other component to translate our text, the headers are set dynamically.
The problem is that after the first init, the headers are not update.
I propose this little pr to solve this problem, if you think that I can improve my stuff, say me how.
For some reason the
notify: trueon the header property doesn't fire theheader-changedevent! I'm doing it manually withthis.fire...Thx for your time.