Fix/layer options tabbing #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopenguin
requested review from
warm-coolguy and
oeninghe-dataport
as code owners
|
Woops e1f59d6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When opening layer options via keyboard the focus was lost. Now, the back button or the options button are focused after opening / closing.
I encountered an issue when closing the options menu that is resolved by using
setTimeout. I kinda dislike the solution as this should not be needed as we are already in the next tick so the DOM should've been rerendered. Thus, I am open for other solutions!Instructions for local reproduction and review
npm run dish:devand open / close the options menu via keyboard. The respective button should be focused afterwards.Pull Request Checklist (for Assignee)
[] Functionality has been tested on a smartphoneUI has been tested in the following tools regarding accessibility (only regarding functionality affected in this PR)