All fixes and issues in VisualEvent I've made #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
July 19, 2012 13:10
…plit, reuse result of #indexOf
…whitespace trimmed
|
Fantastic - thank you. Its a bit of a busy time for me at the moment, so unfortunately I don't have much time I can spend on Visual Event at the moment, but I will review these changes soon and merge them in. |
|
Sorry for bothering. Do you have already looked at my changes? |
|
Not yet - sorry. I've been tied up with contract work recently, but the github message is sitting in my inbox waiting for me to look at it! I'll get to it soon :-) |
|
Any progress in merging this request? |
|
Really sorry - I've just not had the time I want to to work on visual event recently. I really do want to get back to it soon though! |
|
And its gone.... :D Move with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I've made my repo and fixed all things I've mentioned in my pull requests and issues. Please take a look.