-
Notifications
You must be signed in to change notification settings - Fork 11
chore: Gitlab e2e tests #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
47eb0da to
50a891c
Compare
50a891c to
9c627c7
Compare
5ea5eeb to
fa5d13b
Compare
7e16243 to
20b5ec5
Compare
4436a6f to
a00849f
Compare
a00849f to
1edd749
Compare
a44f5a9 to
6df21d6
Compare
2779cdc to
bb948fd
Compare
7f861f5 to
cbcab4f
Compare
0027132 to
17ce833
Compare
1909e6c to
28c00b4
Compare
| device_type = inference_accelerator.value.device_type | ||
| } | ||
| } | ||
| # Fargate incompatible parameter on v6.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We restrict support for the package to AWS provider version 5.77.0+. The CI decided to pick up the most recent version being 6.0.0. This caused an error to be thrown for the inference accelerator being an unexpected field.
The inference accelerator was never a supported field in Fargate, however, we still had code written to attempt to create an inference accelerator if the user defined one. Originally, this would only throw an error if the user actually defined an accelerator, but now it throws an error even if the value is null.
Therefore, we can remove the inference_accelerator field without any negative reverse impacts on 5.77+. The only difference will be that we ignore their incorrectly defined inference_accelerator field on ECS Fargate tasks because it should never be there in the first place.
81476e2 to
5f395ce
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
mergequeue build completed successfully, but the github api returned an error while merging the pr DetailsError: PUT https://api.github.com/repos/DataDog/terraform-aws-ecs-datadog/pulls/26/merge: 405 Merge commits are not allowed on this repository. [] (Request ID: 6B61:130718:8CE608:1197838:685C7961) FullStacktrace: |
What does this PR do?
Runs the integration tests for the terraform-aws-ecs-datadog.
Also removes
inference_acceleratoras a configuration option for the ECS task definition due to incompatibility with AWS provider v6.Motivation
CI
Describe how you validated your changes
CI
Additional Notes
terraform applycommand requiresecs:DescribeTaskDefinitionon*task definition resources. Otherwise it throws an error stating"Couldn't find resource"without surfacing a permission denied error.Similarly
terraform destroycommand requiresecs:DeregisterTaskDefinitionon*