Skip to content

Conversation

@gabedos
Copy link
Collaborator

@gabedos gabedos commented Jun 17, 2025

What does this PR do?

Runs the integration tests for the terraform-aws-ecs-datadog.

  1. Creates the task definitions in the specified AWS account.
  2. Verifies expected attributes of the task definitions
  3. Deletes the task definitions

Also removes inference_accelerator as a configuration option for the ECS task definition due to incompatibility with AWS provider v6.

Motivation

CI

Describe how you validated your changes

CI

Additional Notes

terraform apply command requires ecs:DescribeTaskDefinition on * task definition resources. Otherwise it throws an error stating "Couldn't find resource" without surfacing a permission denied error.

Similarly terraform destroy command requires ecs:DeregisterTaskDefinition on *

@gabedos gabedos force-pushed the gabedos/gitlab-ci-e2e branch 2 times, most recently from 47eb0da to 50a891c Compare June 18, 2025 15:00
@gabedos gabedos force-pushed the gabedos/gitlab-ci-e2e branch from 50a891c to 9c627c7 Compare June 18, 2025 15:11
@gabedos gabedos force-pushed the gabedos/gitlab-ci-e2e branch from 5ea5eeb to fa5d13b Compare June 18, 2025 17:17
@gabedos gabedos force-pushed the gabedos/gitlab-ci-e2e branch from 7e16243 to 20b5ec5 Compare June 18, 2025 17:31
@gabedos gabedos force-pushed the gabedos/gitlab-ci-e2e branch from 4436a6f to a00849f Compare June 20, 2025 13:45
@gabedos gabedos force-pushed the gabedos/gitlab-ci-e2e branch from a00849f to 1edd749 Compare June 20, 2025 14:53
@gabedos gabedos force-pushed the gabedos/gitlab-ci-e2e branch from a44f5a9 to 6df21d6 Compare June 20, 2025 17:09
@gabedos gabedos force-pushed the gabedos/gitlab-ci-e2e branch from 2779cdc to bb948fd Compare June 20, 2025 19:11
@gabedos gabedos force-pushed the gabedos/gitlab-ci-e2e branch from 7f861f5 to cbcab4f Compare June 22, 2025 22:04
@gabedos gabedos force-pushed the gabedos/gitlab-ci-e2e branch from 0027132 to 17ce833 Compare June 23, 2025 14:23
@gabedos gabedos force-pushed the gabedos/gitlab-ci-e2e branch from 1909e6c to 28c00b4 Compare June 23, 2025 14:57
@gabedos gabedos marked this pull request as ready for review June 23, 2025 14:59
@gabedos gabedos requested a review from a team as a code owner June 23, 2025 14:59
device_type = inference_accelerator.value.device_type
}
}
# Fargate incompatible parameter on v6.0.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We restrict support for the package to AWS provider version 5.77.0+. The CI decided to pick up the most recent version being 6.0.0. This caused an error to be thrown for the inference accelerator being an unexpected field.

The inference accelerator was never a supported field in Fargate, however, we still had code written to attempt to create an inference accelerator if the user defined one. Originally, this would only throw an error if the user actually defined an accelerator, but now it throws an error even if the value is null.

Therefore, we can remove the inference_accelerator field without any negative reverse impacts on 5.77+. The only difference will be that we ignore their incorrectly defined inference_accelerator field on ECS Fargate tasks because it should never be there in the first place.

@gabedos gabedos force-pushed the gabedos/gitlab-ci-e2e branch from 81476e2 to 5f395ce Compare June 25, 2025 15:44
@gabedos
Copy link
Collaborator Author

gabedos commented Jun 25, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 25, 2025

View all feedbacks in Devflow UI.

2025-06-25 22:30:54 UTC ℹ️ Start processing command /merge


2025-06-25 22:30:58 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 0s (p90).


2025-06-25 22:34:15 UTC 🚨 MergeQueue: This merge request is in error

mergequeue build completed successfully, but the github api returned an error while merging the pr

Details

Error: PUT https://api.github.com/repos/DataDog/terraform-aws-ecs-datadog/pulls/26/merge: 405 Merge commits are not allowed on this repository. [] (Request ID: 6B61:130718:8CE608:1197838:685C7961)

FullStacktrace:
activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 41, startedEventID: 42, identity: 1@github-worker-8f7cd5c59-hw2fc@): PUT https://api.github.com/repos/DataDog/terraform-aws-ecs-datadog/pulls/26/merge: 405 Merge commits are not allowed on this repository. [] (Request ID: 6B61:130718:8CE608:1197838:685C7961) (type: GitFailure, retryable: false): PUT https://api.github.com/repos/DataDog/terraform-aws-ecs-datadog/pulls/26/merge: 405 Merge commits are not allowed on this repository. [] (type: ErrorResponse, retryable: true)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants