Skip to content

[golang] Activate CSS Test_Client_Stats::test_top_level_service#7278

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
inigo/css-activate-go-top-level-service
Jul 8, 2026
Merged

[golang] Activate CSS Test_Client_Stats::test_top_level_service#7278
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
inigo/css-activate-go-top-level-service

Conversation

@ichinaski

@ichinaski ichinaski commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Motivation

APMSP-3667 / APMSP-3042. dd-trace-go now populates the payload-level Service field in the client-side stats payload on main (2.11.0-dev), so Test_Client_Stats::test_top_level_service passes there. The latest release (v2.9.1) does not set it yet (CI showed assert '' == 'weblog' on the prod jobs), so the test must stay missing_feature for released versions.

Changes

Version-gate tests/stats/test_stats.py::Test_Client_Stats::test_top_level_service at v2.11.0-dev in manifests/golang.yml (was an unconditional missing_feature). Expected-pass on the dev build, skipped on the released version until 2.11.0 ships.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/golang.yml                                                    @DataDog/dd-trace-go-guild

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a6f41aa | Docs | Datadog PR Page | Give us feedback!

…v2.11.0-dev

dd-trace-go sets the payload-level Service field starting on main
(2.11.0-dev, APMSP-3042); the latest release (v2.9.1) does not, so gate the
test at v2.11.0-dev rather than removing the marker. Expected-pass on dev,
skipped on the released version until 2.11.0 ships.

APMSP-3667
@ichinaski ichinaski force-pushed the inigo/css-activate-go-top-level-service branch from e9db84b to a6f41aa Compare July 8, 2026 09:09
@ichinaski ichinaski marked this pull request as ready for review July 8, 2026 12:24
@ichinaski ichinaski requested a review from a team as a code owner July 8, 2026 12:24
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 77e6da9 into main Jul 8, 2026
48 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the inigo/css-activate-go-top-level-service branch July 8, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants