[golang] Activate CSS Test_Client_Stats::test_top_level_service#7278
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoJul 8, 2026
Merged
Conversation
Contributor
|
|
Contributor
🎉 All green!🧪 All tests passed 🔗 Commit SHA: a6f41aa | Docs | Datadog PR Page | Give us feedback! |
…v2.11.0-dev dd-trace-go sets the payload-level Service field starting on main (2.11.0-dev, APMSP-3042); the latest release (v2.9.1) does not, so gate the test at v2.11.0-dev rather than removing the marker. Expected-pass on dev, skipped on the released version until 2.11.0 ships. APMSP-3667
e9db84b to
a6f41aa
Compare
kakkoyun
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
APMSP-3667 / APMSP-3042. dd-trace-go now populates the payload-level
Servicefield in the client-side stats payload onmain(2.11.0-dev), soTest_Client_Stats::test_top_level_servicepasses there. The latest release (v2.9.1) does not set it yet (CI showedassert '' == 'weblog'on theprodjobs), so the test must staymissing_featurefor released versions.Changes
Version-gate
tests/stats/test_stats.py::Test_Client_Stats::test_top_level_serviceatv2.11.0-devinmanifests/golang.yml(was an unconditionalmissing_feature). Expected-pass on the dev build, skipped on the released version until 2.11.0 ships.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present