Skip to content

[nodejs] Fix SSI tests after new major release#7274

Closed
CarlesDD wants to merge 3 commits into
mainfrom
ccapell/fix-ssi-appsec-nodejs-v6
Closed

[nodejs] Fix SSI tests after new major release#7274
CarlesDD wants to merge 3 commits into
mainfrom
ccapell/fix-ssi-appsec-nodejs-v6

Conversation

@CarlesDD

@CarlesDD CarlesDD commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Motivation

Update SSI test after dd-trace v6 release

Changes

Bump CI dev/staging test version of dd-trace.
Cap SSI tests with the correct runtime / dd-trace version

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@datadog-datadog-prod-us1

This comment has been minimized.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/docker_ssi/test_docker_ssi.py                                     @DataDog/injection-platform
tests/docker_ssi/test_docker_ssi_appsec.py                              @DataDog/injection-platform
tests/docker_ssi/test_docker_ssi_crash.py                               @DataDog/injection-platform
utils/build/ssi/base/install_script_ssi.sh                              @DataDog/system-tests-core

@CarlesDD CarlesDD changed the title [nodejs] Fix SSI test after new release [nodejs] Fix SSI test after new major release Jul 7, 2026
@CarlesDD CarlesDD changed the title [nodejs] Fix SSI test after new major release [nodejs] Fix SSI tests after new major release Jul 7, 2026
@CarlesDD CarlesDD marked this pull request as ready for review July 7, 2026 09:53
@CarlesDD CarlesDD requested review from a team as code owners July 7, 2026 09:53

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd14c44d7d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread tests/docker_ssi/test_docker_ssi.py Outdated

@robertomonteromiguel robertomonteromiguel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar PR: #7271

@CarlesDD

CarlesDD commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favour #7271

@CarlesDD CarlesDD closed this Jul 7, 2026
@CarlesDD CarlesDD deleted the ccapell/fix-ssi-appsec-nodejs-v6 branch July 7, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants