Skip to content

Conversation

@wantsui
Copy link
Contributor

@wantsui wantsui commented Nov 14, 2025

Motivation

The reports are uploaded to the backend but @bojbrook found that the unexpected otel_collector type fails the update.

Changes

This goal of this change is to have a generic value for this field instead so @colin-higgins can make a more generic backend change.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@wantsui wantsui requested a review from a team as a code owner November 14, 2025 19:23
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

CODEOWNERS have been resolved as:

tests/otel_postgres_metrics_e2e/test_postgres_metrics.py                @DataDog/system-tests-core
utils/_features.py                                                      @DataDog/system-tests-core

@wantsui wantsui enabled auto-merge (squash) November 14, 2025 20:37
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to discuss, because the component abstraction is very central in system-tests, and by using a generic value, you won't be able to use any manifest mechanism. Could you add a meeting with @colin-higgins and myself ?

@quinna-h
Copy link
Contributor

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Nov 18, 2025

View all feedbacks in Devflow UI.

2025-11-18 20:02:14 UTC ℹ️ Start processing command /merge


2025-11-18 20:02:26 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-11-18 20:09:33 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@wantsui wantsui merged commit b9f54e7 into main Nov 18, 2025
392 checks passed
@wantsui wantsui deleted the rename-otel-scenario-version branch November 18, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants