-
Notifications
You must be signed in to change notification settings - Fork 14
Change reporting from otel_collector to generic for the Otel Scenario #5720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
cbeauchesne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to discuss, because the component abstraction is very central in system-tests, and by using a generic value, you won't be able to use any manifest mechanism. Could you add a meeting with @colin-higgins and myself ?
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
This pull request was merged directly. |
Motivation
The reports are uploaded to the backend but @bojbrook found that the unexpected
otel_collectortype fails the update.Changes
This goal of this change is to have a generic value for this field instead so @colin-higgins can make a more generic backend change.
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present